Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app, shared-data, components): support for stacking multiple labware #16615

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Oct 28, 2024

fix PLAT-499, PLAT-500, PLAT-502, PLAT-548

Overview

This PR adds front end support for displaying stacks of multiple of the same labware (currently only TC lids are allowed) in all deck map and labware list locations

Test Plan and Hands on Testing

I have done the following, more testing always welcome!
Smoke test protocol setup for a variety of protocols with different stack types
On desktop only, test protocol setup liquids map view
On desktop and ODD, test: protocol setup labware list view and map view, labware stacking modal, and protocol details deck map

protocol deck view Screen Shot 2024-10-23 at 9 46 36 PM Screen Shot 2024-10-24 at 4 29 56 PM Screen Shot 2024-10-27 at 10 31 31 PM Screen Shot 2024-10-27 at 10 31 35 PM

Screen Shot 2024-10-28 at 1 59 53 PM

Changelog

  1. Create two new utils to get the top most labware in a stack (previous logic assumed the second stacked labware was the top) and to get the number of stacked, alike labware and the base location of that alike stack
  2. Edit all places we show a deck map for protocol setup or protocol details to use this new util to accurately represent the topmost labware in each stack
  3. Edit labware list view on ODD and Desktop to represent stacks of multiple like labware in one line item
  4. Edit labware stack modal represent stacks of multiple like labware in one line item, show png renders for tc lid and deck riser
  5. Add SVG special cases for TC lid and deck riser

Review requests

Look through the code for errors/questions (I had to refactor deck map stuff a bit but have tested thoroughly)

Risk assessment

Medium - impacts all deck map and protocol details and setup instances

@smb2268 smb2268 requested a review from ncdiehl11 October 28, 2024 18:09
@smb2268 smb2268 force-pushed the app_multi-labware-stack branch from 8b5a0f9 to 024470f Compare October 28, 2024 18:15
@smb2268 smb2268 requested review from vegano1 and mjhuff October 28, 2024 18:38
@smb2268 smb2268 marked this pull request as ready for review October 28, 2024 18:38
@smb2268 smb2268 requested a review from a team as a code owner October 28, 2024 18:38
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! One nit.

app/src/molecules/LabwareStackModal/LabwareStackModal.tsx Outdated Show resolved Hide resolved
@ecormany ecormany assigned ecormany and unassigned ecormany Oct 28, 2024
Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks great, thank you!

@smb2268 smb2268 merged commit 1a91bf4 into edge Oct 29, 2024
46 checks passed
@smb2268 smb2268 deleted the app_multi-labware-stack branch October 29, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants